Skip to content

fs: move DEP0187 to End-of-Life - #67494

Open
jasnell wants to merge 2 commits into
nodejs:mainfrom
jasnell:fs-eol-dep0187
Open

jasnell wants to merge 2 commits into
nodejs:mainfrom
jasnell:fs-eol-dep0187

Conversation

@jasnell

@jasnell jasnell commented Nov 15, 2026

Copy link
Copy Markdown
Member

Passing an invalid argument type to fs.existsSync() now throws ERR_INVALID_ARG_TYPE instead of returning false. Other invalid paths, such as strings containing null bytes or non-file: URLs, continue to return false.

This has been a runtime deprecation since v24.0.0.

Refs: #55753
Refs: #55892

Passing an invalid argument type to fs.existsSync() now throws
ERR_INVALID_ARG_TYPE instead of returning false. Other invalid paths,
such as strings containing null bytes or non-file: URLs, continue to
return false.

This has been a runtime deprecation since v24.0.0.

Refs: nodejs#55753
Refs: nodejs#55892
Assisted-by: Claude
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell
jasnell requested a review from a team November 15, 2026 17:02
@jasnell jasnell added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. commit-queue-squash PRs the Commit Queue should land as one squashed commit. labels Nov 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/userland-migrations

@nodejs-github-bot nodejs-github-bot added the fs Issues and PRs related to file-system APIs and the fs module. label Nov 15, 2026
Comment thread doc/api/deprecations.md Resolved
@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Nov 15, 2026
Comment thread doc/api/fs.md Resolved
Co-authored-by: James M Snell <jasnell@gmail.com>
@codecov

codecov Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.66%. Comparing base (d105ef7) to head (f5b988d).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #67494      +/-   ##
==========================================
- Coverage   90.67%   90.66%   -0.01%     
==========================================
  Files         799      799              
  Lines      280245   280240       -5     
  Branches    54125    54118       -7     
==========================================
- Hits       254100   254072      -28     
- Misses      16280    16291      +11     
- Partials     9865     9877      +12     
Files with missing lines Coverage Δ
lib/fs.js 97.20% <100.00%> (-0.01%) ⬇️

... and 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcollina mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 15, 2026
@github-actions github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. Only starts once the PR has an approving review. label Nov 15, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

@gurgunday gurgunday left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gurgunday gurgunday added the author ready PRs with CI started, the required approvals, and no outstanding review comments. label Nov 15, 2026
@LiviaMedeiros LiviaMedeiros added the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Nov 16, 2026
@github-actions github-actions Bot removed the resume-ci Add this label to resume the latest eligible Jenkins CI run on a PR with an approving review. label Nov 16, 2026
@nodejs-github-bot

Copy link
Copy Markdown
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs with CI started, the required approvals, and no outstanding review comments. commit-queue-squash PRs the Commit Queue should land as one squashed commit. deprecations Issues and PRs related to deprecations. fs Issues and PRs related to file-system APIs and the fs module. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants